This repository was archived by the owner on Mar 21, 2022. It is now read-only.
Add --cpus options to a container#1034
Open
gabrielsvinha wants to merge 1 commit intospotify:masterfrom
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1034 +/- ##
=========================================
Coverage 67.39% 67.39%
Complexity 774 774
=========================================
Files 176 176
Lines 3233 3233
Branches 367 367
=========================================
Hits 2179 2179
Misses 897 897
Partials 157 157 |
Contributor
|
@gabrielsvinha just wondering about the above. |
|
Can someone comment on this? There is a CpuCount, but is it really Windows only? It's located under the HostConfig. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the class
HostConfigto receive the propertycpuswhen creating a new container.Add unit test to the specified parameters.
Solves #959